Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update vc-api comply vcdm v2 #221

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Conversation

namhoang1604
Copy link
Contributor

@namhoang1604 namhoang1604 commented Oct 7, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR refactors the VC-api to comply the VC-api test suite

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

huynguyen-hl and others added 4 commits October 4, 2024 17:31
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@huynguyen-hl
Copy link
Contributor

@namhoang1604, Could this implementation integrate seamlessly with the credentialStatus (bitstringStatusList)?

@namhoang1604
Copy link
Contributor Author

@namhoang1604, Could this implementation integrate seamlessly with the credentialStatus (bitstringStatusList)?

That is quite big, I did mention to implement it in another PR

@namhoang1604 namhoang1604 merged commit 4ce0e09 into next Oct 7, 2024
1 check failed
@namhoang1604 namhoang1604 deleted the vcdm-v2-compliance branch October 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants