Agregando log de errores a superset #34
Merged
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdata99
reviewed
Feb 22, 2025
avdata99
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
@germankay I've made some changes
Please, testin locally and if it work, we are ready to merge
|
@avdata99 I made changes because it was failing in the local environment. |
avdata99
reviewed
Feb 25, 2025
Comment on lines
+226
to
+228
| # Si la respuesta es una redirección (302), la consideramos válida para el login | ||
| if response.status_code == 302: | ||
| return response, None |
There was a problem hiding this comment.
Suggested change
| # Si la respuesta es una redirección (302), la consideramos válida para el login | |
| if response.status_code == 302: | |
| return response, None |
This is probably non required
raise_for_status should not raise for 302
Is required to not follow the redirection?
If not required, delete it
avdata99
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related unckan/ckan-env#37 (comment)
fixes #37
Una vez mezclado el PR de Test #27 Agregamos test para esta funcion