-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FitNesseRunner lacks an option to override variables #1152
Comments
provider for custom variables
As a suggestion to 'workaround' this issue you could consider using my plugin (https://github.com/fhoeben/hsac-fitnesse-plugin, sample usage https://raw.githubusercontent.com/fhoeben/hsac-fitnesse-fixtures/master/wiki/FitNesseRoot/HsacExamples/SymbolSamples.wiki). It defines a I use this to override variables when running tests (with the jUnit FitNesseRunner) on build server. |
The hsac-fitnesse-plugin option also should allow for -D vm arguments at the command line. I'm going to close this with a viable workaround. |
When running with fitnesse-standalone, it is possible to override variables by adding url params. Internally this is done by parsing the params and creating an UrlPathVariableSource from it. Later during variable resolution, UserVariable source checkis if the page variable source is of type UrlPathVariableSource, and if so, it is used with higher priority than the other variable sources. This is an implementation that is full of implicit assumptions - maybe this should be re-written some day.
When using FitNesseRunner, there's no option to override variables this way. The reason is that FitNesseRunner does not call context.getRootPage() with a map of values.
Since all those calls are in private methods, there's also no way to create a custom FitNesseRunner that calls the method with Map arguments.
I propose to
a) refactor FitNesseRunner to allow overriding this behaviour
b) define a proper way to set custom parameters (e.g. provide a class that does it by using a annotation)
The text was updated successfully, but these errors were encountered: