Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Basic Authentication: Don't fail on colons (":") in passwords #1485

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

manubahr
Copy link
Contributor

fitnesse.http.Request#getCredentials() fails to split the basic authentication header value correctly if the password contains one or more colons (":"). The splitting has to stop after the 1st colon separating user-id and password. Following colons are part of the password.

See:

Furthermore, a user-id containing a colon character is invalid, as
the first colon in a user-pass string separates user-id and password
from one another; text after the first colon is part of the password.

@fhoeben
Copy link
Collaborator

fhoeben commented Feb 14, 2024

@manubahr do you mind resolving the merge conflicts so we can merge directly?

Thanks for your contributions!

@fhoeben fhoeben merged commit 56f07fe into unclebob:master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants