Added workaround for Moment instances #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the lib is unable to deal with Moment instances. I therefore added a workaround to avoid processing them.
I'd understand if you don't want to merge this, as it is undesirable to handle workarounds for miscellaneous libraries, but you can get rid of it in your next major version (where you said you'd implement custom strategies, allowing such stuff to happen in userland) and allow people to use your library with Moment, the most popular date/time management library in the JS ecosystem, in the meantime.
Best regards!