Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Thread Groups - Allow to run on JMeter lower than 5.2 #691

Closed
wants to merge 1 commit into from

Conversation

3dgiordano
Copy link
Contributor

The latest change made in Custom Thread Groups version 3.0 allows the new JMeterThread from JMeter 5.2 to be used in ConcurrencyThreadGroup, ArrivalsThreadGroup and FreeFormArrivalsThreadGroup, but breaks compatibility with JMeter older than 5.2.

I am making a proposal to allow the use of JMeters older than 5.2 using the old JMeterThread constructor.
This applies only to ConcurrencyThreadGroup, ArrivalsThreadGroup and FreeFormArrivalsThreadGroup.

Apologies for not realizing earlier that it was possible to incorporate this possibility, I later realized that it would be easy to incorporate it and thus surely not break the execution of those who still use JMeter lower than 5.2.

I can incorporate this "version checking" and disable the new field in the UI if necessary, although it is adding code for probably a small group of users.

I look forward to hearing what you think about this proposal.

@undera
Copy link
Owner

undera commented Jan 22, 2025

If the majority of users is using 5.2+, then it's not worth the complication. Users can install the older version as a workaround

@3dgiordano
Copy link
Contributor Author

@undera OK.

I'm going to close the PR, as it doesn't seem to be important.
Thanks again

PS: I noticed that the build for version 3.0 is already in maven, I'm going to proceed to create the new PR with the description of the new version and update the wiki to indicate the compatibility information with JMeter versions.

@3dgiordano 3dgiordano closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants