Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAI Inverse Estimation #337

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

XAI Inverse Estimation #337

wants to merge 53 commits into from

Conversation

annahedstroem
Copy link
Member

@annahedstroem annahedstroem commented Feb 23, 2024

Description

  • Docstring fixes in all metrics and fixed typos across code base
  • Added call_kwargs_che
  • Replaced assertions for attributions with warnings
  • InveseEstimation implementation
    • tests for pixel flipping and localisation
    • implementation next to base.py
    • plotting functionality
  • fixes in metric base class, including adding the call params, making hem available as self.attributes
  • added return_auc_per_sampel to RegionPerturbation

Minimum acceptance criteria

  • Specify what is necessary for the PR to be merged with the main branch.
  • @mentions of the person that is apt to review these changes e.g., @annahedstroem

Copy link
Member Author

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@annahedstroem annahedstroem changed the title XAI inverse estimation XAI Inverse Estimation Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.81481% with 34 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (6857561) to head (24ec8fa).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
quantus/metrics/inverse_estimation.py 79.26% 17 Missing ⚠️
quantus/helpers/model/pytorch_model.py 12.50% 7 Missing ⚠️
quantus/helpers/warn.py 69.56% 7 Missing ⚠️
quantus/evaluation.py 88.88% 1 Missing ⚠️
...uantus/metrics/faithfulness/region_perturbation.py 80.00% 1 Missing ⚠️
quantus/metrics/faithfulness/road.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   91.15%   90.58%   -0.58%     
==========================================
  Files          66       67       +1     
  Lines        3925     4047     +122     
==========================================
+ Hits         3578     3666      +88     
- Misses        347      381      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first round of review ok

Copy link
Member Author

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another review, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants