UNDERTOW-2305 Fix NPE in Http2ClearClientProvider #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartwdouglas @fl4via I think this is just a typo causing a NPE, but I'm not sure about the conversion method from HTTP2_SETTINGS_MAX_HEADER_LIST_SIZE to MAX_HEADER_SIZE. Is it suppose to be 1-to-1, or should the value be perhaps mutliplied by some factor? (It's a blocker on EAP8.) |
fl4via
approved these changes
Oct 10, 2023
@TomasHofman yes, it is 1 to 1. Thanks for the PR! |
fl4via
added
the
next release
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/UNDERTOW-2305
https://issues.redhat.com/browse/JBEAP-25508