Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2357] remove JDK check in Http2 exapmle #1570

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[UNDERTOW-2357] remove JDK check in Http2 exapmle #1570

merged 1 commit into from
Jun 26, 2024

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Mar 18, 2024 •
edited
Loading

@baranowb baranowb requested review from fl4via and ropalka March 18, 2024 10:36
@baranowb baranowb added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting peer review PRs that edit core classes might require an extra review labels Mar 18, 2024
@ropalka ropalka removed the waiting peer review PRs that edit core classes might require an extra review label Mar 18, 2024
@baranowb
Copy link
Contributor Author

Build require JDK11 anyway.

fl4via
fl4via previously requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@fl4via fl4via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix typo both in the commit and PR message

@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Apr 19, 2024
@baranowb baranowb changed the title [UNDERTOW-2357] remove JDK check in Http2 exxapmle [UNDERTOW-2357] remove JDK check in Http2 exapmle Jun 24, 2024
@baranowb baranowb dismissed fl4via’s stale review June 24, 2024 10:53

again, cant mark as resolved....

@baranowb baranowb added the next release This PR will be merged before next release or has already been merged (for payload double check) label Jun 24, 2024
@baranowb baranowb merged commit 0b2497e into undertow-io:main Jun 26, 2024
34 checks passed
@baranowb baranowb mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via fl4via left review comments

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @ropalka @fl4via