Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2383] do not canonicalize query string in sendRedirect location #1588

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[UNDERTOW-2383] do not canonicalize query string in sendRedirect location #1588

merged 1 commit into from
Jun 14, 2024

Conversation

aogburn
Copy link
Contributor

@aogburn aogburn commented Apr 26, 2024

@baranowb baranowb added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels May 6, 2024
@baranowb baranowb requested review from fl4via and baranowb May 6, 2024 06:04
baranowb
baranowb approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@baranowb baranowb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAIR.

@soul2zimate
Copy link
Contributor

@fl4via Could you review this PR? This is needed by the downstream

@fl4via fl4via added bug fix Contains bug fix(es) next release This PR will be merged before next release or has already been merged (for payload double check) and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Jun 10, 2024
@fl4via fl4via added the waiting CI check Ready to be merged but waiting for CI check label Jun 10, 2024
@fl4via fl4via force-pushed the UNDERTOW-2383 branch 2 times, most recently from 8658ab8 to 5d02f56 Compare June 13, 2024 22:15
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Jun 14, 2024
@fl4via fl4via merged commit 34d4d15 into undertow-io:master Jun 14, 2024
34 checks passed
@ivassile ivassile mentioned this pull request Jun 18, 2024
Merged
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baranowb baranowb baranowb approved these changes

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
bug fix Contains bug fix(es)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aogburn @soul2zimate @fl4via @baranowb