Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2391] CVE-2023-5685 bump xnio to bring in fix for the CVE #1592

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

smmathews-brandwatch
Copy link
Contributor

Bumps xnio from 3.8.8.Final to 3.8.14.Final, which is the latest version and the first version to fix CVE-2023-5685

jira ticket is https://issues.redhat.com/browse/UNDERTOW-2391

@romabaz
Copy link

romabaz commented May 17, 2024

@smmathews-cision-us thanks for bringing this into attention.

@fl4via fl4via changed the title bump xnio to bring in fix for CVE-2023-5685 [UNDERTOW-2391] bump xnio to bring in fix for CVE-2023-5685 May 20, 2024
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check dependency upgrade Pull requests that update a dependency file failed CI Introduced new regession(s) during CI check labels May 20, 2024
@fl4via
Copy link
Member

fl4via commented May 20, 2024

Unfortunately tests are failing, I'll need to investigate before merging this one

@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label May 20, 2024
@romabaz romabaz mentioned this pull request Jun 12, 2024
@romabaz
Copy link

romabaz commented Jun 12, 2024

Hello, @fl4via, do you think it would be unsafe for undertow consumers to exclude and replace xnio in pom as transitive dependency, e.g.:

<dependency>
      <groupId>io.undertow</groupId>
      <artifactId>undertow-core</artifactId>
      <version>2.3.13.Final</version>
      <exclusions>
          <exclusion>
              <groupId>org.jboss.xnio</groupId>
              <artifactId>xnio-xnio</artifactId>
          </exclusion>
      </exclusions>
</dependency>
<dependency>
        <groupId>org.jboss.xnio</groupId>
        <artifactId>xnio-nio</artifactId>
        <version>3.8.14.Final</version>
</dependency>

I'm asking, because we have a vulnerability report pending on undertow on that and need to deal with it.

@fl4via
Copy link
Member

fl4via commented Jun 14, 2024

Hi @romabaz ! I spent the past two weeks investigating this regression and testing a fix for XNIO in internal labs to make sure the final solution to this regression would not cause other regressions of any sorts, specially taking into consideration Undertow and its interaction with WildFly/JBoss Remoting corner scenarios. That's why this PR has been "stalled".
Everything is ready now for release. XNIO 3.8.16.Final has just been tagged with the tested fix. I advise you to wait for the release, since it will be done within the next hours. I appreciate your patience and I apologize for the delay.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
@fl4via fl4via changed the title [UNDERTOW-2391] bump xnio to bring in fix for CVE-2023-5685 [UNDERTOW-2391] CVE-2023-5685 bump xnio to bring in fix for the CVE Jun 14, 2024
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check and removed failed CI Introduced new regession(s) during CI check waiting CI check Ready to be merged but waiting for CI check labels Jun 14, 2024
@fl4via fl4via merged commit 0e7c5ab into undertow-io:master Jun 14, 2024
34 checks passed
@romabaz
Copy link

romabaz commented Jun 14, 2024

@fl4via , thank you for your prompt response!

@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency upgrade Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants