[UNDERTOW-2526] Rename DeploymentInfo methods dealing with async context timeout containing typo #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext timeout containing typo. It is safe to rename them because this change wasn't backported yet. There is no release containing the typo.
ropalka
force-pushed
the
UNDERTOW-2526
branch
from
4e3d58b to
ff0e3c9
Compare
ropalka
changed the title
baranowb
approved these changes
Nov 25, 2024
|
I wonder how should those be handled in lower branches. Might look ugly with two similar methods, but breaking binary compat is a bad thing. |
|
This change wasn't backported yet to any branch @baranowb so we're lucky. |
jasondlee
approved these changes
Nov 27, 2024
baranowb
added
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/UNDERTOW-2526
Note it is safe to rename these methods because original PR that introduced them wasn't back ported yet.