Added function to handle None inputs in bcs #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a fix for #149 ? |
|
Yes, it's a fix for #149. When declaring boundary conditions, the user should put in None if that corresponding component is unconstrained. Also, the fix does not break the current examples (using sympy.oo for no constraints), but might be good idea if I'm allowed to change them soon. |
julesghub
reviewed
Mar 22, 2024
|
|
||
| import numpy as np | ||
|
|
||
| if hasattr(fn, "__len__"): # BC input is iterable (has __len__ attribute) |
There was a problem hiding this comment.
Instead of python "duck" typing, let's just assume fn is list/tuple of length u.dim for now?
|
Checking - are you happy with this, @julesghub ? We should not leave the branch hanging forever. |
|
Good point @lmoresi. |
All conditions are now turned into a list before conversion. Modifying test to test the conversion code.
|
@jcgraciosa, please review my changes and we can discuss further if needed. |
jcgraciosa
commented
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to SolverBaseClass to convert BCs inputted by the user as None into sympy.oo for subsequent use by the solver. Also added some type checks and handlers and it should not break the current example scripts (based on some tests).