Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding basic mesh, scalar, and vector plotting fns #224

Merged

Conversation

gthyagi
Copy link
Contributor

@gthyagi gthyagi commented Aug 12, 2024

Hi,

I've added basic plotting functions for the mesh, scalar field, and vector field. Please take a look and let me know if you have any suggestions.

Cheers!

@gthyagi gthyagi requested a review from julesghub August 12, 2024 01:26
Copy link
Member

@julesghub julesghub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gthyagi ,

Just looking at this now. Can the if statement contents for each plot function (ie: clip1, clip2) be moved into a single function all plot routines call? If so this would make the code a lot easier to maintain.

@gthyagi
Copy link
Contributor Author

gthyagi commented Aug 13, 2024

Completely agree with you on that, i will make those changes. Thanks

Copy link
Member

@julesghub julesghub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Tyagi! Approved!

@julesghub julesghub merged commit 46bf1d6 into underworldcode:development Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants