Pull JOSS changes to main back into dev #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Dev branch needs to become the 1.0 release for main, (or 3.0 if we want to be consistent with underworld 1 and 2) This is the last major thing in the way of the JOSS release. If there are further bugs, they can be fixed as we find them, but we really need to be in a position to tidy the code and get it reviewed ASAP.
binder is better launched from a separate repository which pulls in the code on demand. This is much faster because of the heavy dependencies.
Minor updates / add QR code to assets
Do this, then we can move it back in a submission branch
…the JOSS paper Expressions should expand in the "where:" section of the solver self-description and a couple of other spots. Added a tensor contraction function as well, but that is probably not of interest to anyone.
#270) …the JOSS paper. Expressions should expand in the "where:" section of the solver self-description and a couple of other spots. Added a rank 2 tensor contraction function as well, but that is probably not of interest to anyone - maybe not even me. Tests are passing
|
Tests are all passing, suggest we bring back these changes and make sure all outstanding PRs are compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.