Fix JSONB expected value in the ARU #982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some column values in the csv can be empty. This fix puts those values in the JSONB field as empty strings rather than nil.
After fixing one of the errors, the
refresh_errors_if_needed
method will go through all the errors again and check the one resolved to remove them from the list.Running down the list of errors, the code searches for the matching_criteria JSONB field to find the existing errors; that is where the mismatch was happening, with the record in the db having nil and the matching value expecting an empty string, so trying to create a new error_record rather than update the preexisting one.
Happy to have a chat if any of the above is not clear