Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pame evaluations #5

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Added pame evaluations #5

wants to merge 4 commits into from

Conversation

spencerldixon
Copy link

No description provided.

@spencerldixon spencerldixon force-pushed the add_pame_evaluations branch 3 times, most recently from a1659a8 to 6608130 Compare June 22, 2018 13:45
@spencerldixon spencerldixon force-pushed the add_pame_evaluations branch from 6608130 to 02a886d Compare June 22, 2018 13:55
Levia
Levia reviewed Jun 22, 2018
View reviewed changes
lib/mailer.rb
@@ -1,3 +1,5 @@
require 'erb'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept running into an error that ERB was being used without explicitly being required, this fixes it. Might be a ruby version thing, can't see the harm in being cautious

Levia
Levia reviewed Jun 22, 2018
View reviewed changes
web/controllers/admin.rb
@@ -1,6 +1,7 @@
module Web; end
require "web/helpers"
require "lib/admin_csv_generator"
require 'sinatra'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I'm not sure what is this require for exactly

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, fixes a warning about things being explicitly required for me

@spencerldixon spencerldixon changed the base branch from master to develop June 25, 2018 08:46
@spencerldixon
Copy link
Author

Work just needs the pame model attributes changing from method to methodology, as method is a reserved word and doesn't play nicely with the tests.

This work is on hold for the time being so will leave the PR open to be picked up in the future. Pame evaluations should NOT show in the API atm.

@stacytalbot
Copy link
Contributor

@Levia @spencerldixon can either of you shed some light on this very old PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levia Levia Levia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerldixon @stacytalbot @Levia