Support specifying the default max number of iterations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either via the UNEXPECTED_CHECK_MAX_ITERATIONS environment variable or the maxiterations=... GET parameter in the browser. Fixes #2.
|
👍 thanks a lot, this is great. Just merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either via the
UNEXPECTED_CHECK_MAX_ITERATIONSenvironment variableor the
maxiterations=...GET parameter in the browser.Fixes #2.
I've tested this manually. Sorry for not including automatic tests -- it would require either using proxyquire or something like the "external" tests we use in Unexpected, both of which would add a bit of complexity. Let me know if you think that's required.