Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade puppeteer to version 4.0.0 #65

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 16, 2020

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ puppeteer (^3.0.0 → ^4.0.0) · Repo

Release Notes

4.0.0

Breaking change: Puppeteer no longer uses Node’s EventEmitter library

As part of our work to make Puppeteer agnostic of its environment we are removing the dependency on Node’s EventEmitter in favour of an event emitter that is not tied to Node. Under the hood we use Mitt, but we extend Mitt with additional functionality to match most of the methods that Node’s EventEmitter provides. The following methods have been removed from Puppeteer classes that extend EventEmitter:

  • eventNames()
  • getMaxListeners()
  • listeners(eventName)
  • prependListener
  • prependOnceListener
  • setMaxListeners(n)
  • rawListeners(eventName)

Additionally all the static methods on the EventEmitter class are not supported:

  • listenerCount(emitter, eventName)
  • defaultMaxListeners
  • errorMonitor

Node’s EventEmitter emitted a newListener event when a listener was added and a removeListener event when one was removed. These are not supported and will not be emitted.

New features and improvements

  • Send/receive debug logs are now split out into separate channels making the logs much clearer (#6017)
  • You can now call isJavaScriptEnabled() on a Puppeteer page to find out if JS is enabled on the page (#5993)

Bug fixes

  • Puppeteer is now much better at killing lingering browser processes, especially when you exit a test run with Ctrl-C (#6011)

Behind the scenes

  • We've started work on a new documentation system that uses TSDoc to generate documentation from our source code and have been porting documentation into code accordingly.

Raw notes

5493494 - chore: mark version 4.0.0
03ab1c1 - fix: improve Ctrl + C support (#6011)
b659969 - chore: migrate away from Node's EventEmitter (#5979)
6e060ce - fix(connection): separate send/receive debug logging (#6017)
c701ea1 - chore: fix npm test command (#6010)
398c16d - chore: fix docs linter (#6009)
4205ff7 - docs(api): remove subheader for non-namespace
3d56a9e - chore: add test configuration options for running tests against multiple products (#5964)
5c91dfb - chore: move index.js into src (#6007)
8a099a0 - docs: replace @return with @returns (#6006)
23f18d8 - docs(new): start documenting the Page class (#6001)
c1d7be3 - docs(api): add copy-pasting text example to Mouse class (#6000)
91eb745 - chore: ensure new-docs are up to date (#5994)
b86ff21 - feat(api): add Page.isJavaScriptEnabled + mark properties as private (#5993)
354f942 - feat: improve error reporting on aarch64 (#5167)
9c656d4 - chore: remove prefers-color-scheme: no-preference (#5990)
83c29d9 - chore: clean lib when running tsc (#5982)
ca8b0d6 - feat(new-docs): migrate Dialog documentation to TSDoc (#5981)
0b3d52a - feat(new-docs): add TSDoc comments to Accessibility (#5971)
086c089 - chore: commit base new-docs (#5973)
0032420 - chore: Introduce API Extractor and start generating documentation (#5967)
ef63c64 - test: check installation with Firefox (#5965)
c2d32b1 - chore: rename image assets
a84e07c - chore: increase readability of Puppeteer diagram (#5947)
58d1eab - chore: mark version v3.3.0-post (#5960)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 25 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 16, 2020
@papandreou papandreou merged commit 5cb4023 into master Jun 19, 2020
@depfu depfu bot deleted the depfu/update/npm/puppeteer-4.0.0 branch June 19, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant