-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream to output devices through sound mode selection #20
Conversation
…etter and works for all apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review and thanks a lot for the audio output selection feature!
Please fix the duplicate output devices and the instance names. The remaining comments are cosmetic things and questions.
I'll add a task in the web-configurator to better scale the sound mode dropdown list, and maybe even make it a free-text entry as for the input/app selection. @martonborzak is there already a sound-mode selection feature in the media-player UI? I couldn't find it :-) |
I am testing modifications.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks again!
The number of calls to self.output_devices
could be reduced, but that's something we can fix with the upcoming speaker group feature.
This PR lets select one ore several output devices to stream audio to.
How it works : at connection, the list of available output devices are retrieved (airplay compatible)
The through the sound mode selection, a list of possible combinations is displayed :
For example if you have 2 homepods e.g "Homepod 1" and "Homepod 2" you will have :
The dropdown list should be improved in the webconfigurator because entries are cropped, otherwise it works perfectly.
I guess this is a temporary approach : the list can grow up fastly if you have many airplay devices. I limited the number of items between 1 (1 device enabled) and 5 (5 devices enabled)