Improved entity handling #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the media-player entity to unavailable, if an entity command is received, but Roon is either not paired or no transport available. This makes the entity unavailable in the UI and prevents further command failures until Roon core becomes available again.
Once the integration is no longer paired to the Roon core, we can't send transport commands anymore. Set the media-player entity states to `unavailable` to indicate the disconnection state in the UI and prevent sending further commands. For the pairing event we may not clear our zone information stored during setup. Also, prevent to dynamically add new zones. Adding or removing zones require to run the integration setup.
zehnm
force-pushed
the
fix/entity-handling
branch
from
02f4de3 to
3d8b32f
Compare
Enable and disable media-player entities if a Roon zone was removed or re-added again.
zehnm
force-pushed
the
fix/entity-handling
branch
from
3d8b32f to
67c2409
Compare
martonborzak
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve entity handling with setting correct state, depending on Roon communication and zones availability. Relates to some issues described in #56:
Set entity state in command handler if Roon is not paired.
Set the media-player entity to unavailable, if an entity command is received, but Roon is either not paired or no transport available.
This makes the entity unavailable in the UI and prevents further command
failures until Roon core becomes available again.
Handle Roon core pairing and unpairing events.
Once the integration is no longer paired to the Roon core, we can't send transport commands anymore. Set the media-player entity states to
unavailableto indicate the disconnection state in the UI and prevent sending further commands.For the pairing event we may not clear our zone information stored
during setup. Also, prevent to dynamically add new zones. Adding or
removing zones require to run the integration setup.
Enable and disable media-player entities if a Roon zone was removed or re-added again.
Other changes: