Add flag for disabling link and text dragging #2080
Conversation
| kOsDesktop, SINGLE_VALUE_TYPE("hide-sidepanel-button")}, | ||
| + {"disable-link-drag", | ||
| + "Disable link drag", | ||
| + "Prevents dragging of links and selected text. ungoogled-chromium flag.", |
There was a problem hiding this comment.
I know its everywhere but is there an actual reason to have two spaces before "ungoogled-chromium flag."?
There was a problem hiding this comment.
Hmm, good catch! I didn't even notice that! Perfectionist in me would be definitely willing to replace all double-spaces unless there is a reason for them to be there.
There was a problem hiding this comment.
Everywhere: Fix formatting issue
breaks production
There was a problem hiding this comment.
I guess, it would be safe to remove all double-spaces since they are not rendered anyways:
There was a problem hiding this comment.
Everywhere: Fix formatting issue
breaks production
What do you mean?
There was a problem hiding this comment.
Still it is funny, how inconsistent it is: there are two spaces after the first sentence, but single spaces further down along this comment.
It could be due to different people with different style preferences making changes to the text 😉.
BTW, @tomasz1986 it would be great if you could test this PR.
I'd love to, but I don't really compile the browser myself 🙁. I've given it a try multiple times, but my hardware isn't really sufficient for compiling large projects yet.
There was a problem hiding this comment.
I was taught an oldschool method of typing growing up so I still have have a habit of adding double-spaces after ending sentences. I probably added that when doing a flag and it got copy/pasted it over to others over time. I guess those could be considered age markers 😛.
There was a problem hiding this comment.
So in the end I hope no one would be against me removing them, right?
There was a problem hiding this comment.
So in the end I hope no one would be against me removing them, right?
That should be fine!
|
I tested the changes (before the dedoublespacing) and it worked as expected. The only thing I noticed is that you still have the commandline flag in the docs instead of adding |
Good point! I'll force-push this whole thing once again and start building again to be sure nothing broke. BTW: should I split the spaces-thing into a separate PR to handle it separately? Would it be reasonable? EDIT: I've rebuilt everything with all the latest changes in this PR and nothing seems to be broken and the newly introduced functionality functions the way I wanted it to. |
|
Ready to merge? |
|
So after some time having this flag enabled it seems to me that some of my clicks get ignored. This never happens without this flag. My suspect is that I have a habit of not stopping my mouse specifically for a click, rather continue it to where I need it next and it is probable that on a hidpi screen this amounts to a "selection mode" for a couple of pixels between mouse DOWN and UP, which makes the click event consumed in "selection". Maybe this could be fixed by adding a condition on selection length or click time. 🤔 |
Implementation of #2055 (comment) through feature flag thanks to help from @Ahrotahn and @networkException.
This allows selecting text from within a link and also allows starting the selection without clearing the existing one.
This is a long link, that I'll use for demonstration of what it is. They say a
picturevideo is worth a thousand words.And here is some more text for demonstration purposes only :)
With the flag enabled following becomes possible:
screen.mp4
PS: I also reordered
--force-punycode-hostnamesto be in alphabetical order.