Fix check_for_lfs_files.sh not working in some shells #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In check_for_lfs_files.sh, we need to query all non-SEE assets. To do this, we have previously used an extended globbing expression in Bash (see `man bash` for details). However, it turns out some bash installations (specifically, some Windows GitBash instances) don't handle this correctly. To avoid this problem, I've replaced the extglob pattern with a git diff exclusion pattern, which should have the same effect while working on more machines.
falko17
added
the
no release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In check_for_lfs_files.sh, we need to query all non-SEE assets. To do this, we have previously used an extended globbing expression in Bash (see
man bashfor details).However, it turns out some bash installations (specifically, some Windows GitBash instances) don't handle this correctly. To avoid this problem, I've replaced the extglob pattern with a git diff exclusion pattern, which should have the same effect while working on more machines.