Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable PopupMenu and Bugfixes #692

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Scrollable PopupMenu and Bugfixes #692

merged 5 commits into from
Jan 26, 2024

Conversation

falko17
Copy link
Collaborator

@falko17 falko17 commented Jan 25, 2024 •
edited
Loading

This makes the PopupMenu scrollable. Specifically, when it reaches a certain size (40% of screen height), it won't grow larger than that, and will display a scrollbar with which the menu can be scrolled (in addition to using the mouse wheel).

Additional changes

  • Since the popup menu now has bounded height, the TreeView has been changed to allow the user to sort the entries by all existing numeric and string attributes, instead of just the pre-selected ones that were present before.
  • Dashboard tests are now allowed to fail when run in context of the CI. Local test runs are not impacted by this.
  • An issue has been fixed in which the TreeView did not re-open properly by pressing Tab if it had been closed by its close icon via the mouse.
  • A bug has been fixed in which only the TreeView for one city has been opened by pressing Tab. Now, upon pressing Tab, the TreeView for every active city is added to the window as a tab.

Closes #679.

@falko17 falko17 added bug Something isn't working Improvement Improvement of existing features labels Jan 25, 2024
@falko17 falko17 requested a review from koschke January 25, 2024 18:05
@falko17 falko17 self-assigned this Jan 25, 2024
koschke
koschke approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Can be merged.

@koschke koschke merged commit 47957f8 into master Jan 26, 2024
10 checks passed
@koschke koschke deleted the 679-scrollable-popupmenu branch January 26, 2024 08:04
koschke added a commit that referenced this pull request Feb 6, 2024
@koschke
#692 Updates due to refactorings of graph providers.
3d68011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koschke koschke koschke approved these changes

Assignees

@falko17 falko17

Labels
bug Something isn't working Improvement Improvement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PopupMenu should be scrollable if it hits a certain size
2 participants
@falko17 @koschke