Remove Rotate and Resize Actions #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee3120a.
- Restructure checks for different resize modes. - Move child objects on vertical resize (up/down).
Implement up/down arrow handle for height adjustment as plane with texture. A billboarding effect makes the handle face main camera.
The up/down resize handle is placed at the camera-facing side of the resized object and the billboarding effect was removed. This prevents the handle from being occluded by child nodes.
- All resize handles are now textured planes showing arrows. - Add dedicated shader for sprites in portal.
Remove gizmos used for rotate and scale from scene SEENewWorld as the actions have been dropped.
tinxx
added
Improvement
falko17
requested changes
Oct 29, 2024
Merged
Apply changes suggested by reviewer @falko17.
falko17
approved these changes
Oct 30, 2024
I currently cannot test AR at all but this fixes the compilation errors. We need someone to test AR regularly because most developers won't be able to do that.
I have removed the VR code paths for rotate as well. However, I currently cannot test VR at all but this fixes the I think we need someone to test VR regularly because most developers won't be able to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR removes the now obsolete actions for scaling and rotating a node along with the gizmos.
The resize node action has been improved to allow for resize on the up-axis. Additionally, sprite handles now indicate the resize direction. The handles use a new dedicated shader that honors portals and transparency. The up/down handle is repositioned to the side of the node that faces the camera so that it should be easily visible without the clutter of adding four of them.
Background:
As node dimensions are usually derived from code metrics, rotation and resize are generally not a good idea.
However, there are exceptions that can be flagged to
AllowManualResize. These are, as of now, the architecture nodes that need to be resized to allow for other nodes being placed on them.