Fix UnicodeDecodeError during installation on Windows: explicitly read README.md with UTF‑8 encoding #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows systems (e.g. CPython 3.11),
pip install membase
fails with:This is caused by the default
open("README.md")
using the system encoding (cp1252 on Windows), which breaks when encountering non-ASCII characters.Fix:
Change:
to:
Impact/Rationale:
Verification:
Successfully tested
pip install -e .
and packaging on Windows with Python 3.11 without errors.Checklist:
encoding="utf‑8"
to README.md file open call