Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace QUnit with Jest #62

Merged
merged 34 commits into from
Sep 19, 2018
Merged

Replace QUnit with Jest #62

merged 34 commits into from
Sep 19, 2018

Conversation

backflip
Copy link
Collaborator

  • Added estatico-jest which provides an environment for running Jest test with Puppeteer (in use in an ongoing client project)
  • Removed QUnit references
  • Rewrote slideshow tests

@backflip
[Chore] estatico-boilerplate: Optimized global client-side namespace
dd3b823
@backflip
[Fix] estatico-boilerplate: Fixed slideshow test after namespace abst…
3edd916 
…raction
@backflip
[Chore] estatico-boilerplate: Changed module class name
9dcfdd4
@backflip
[Chore] estatico-boilerplate: Moved dev styles and scripts into /preview
ce0630b
@backflip
Merge remote-tracking branch 'origin/develop' into feature/namespace
f56af5b
@backflip
Merge remote-tracking branch 'origin/develop' into feature/dev-js
7aabe17
@backflip
Merge branch 'feature/namespace' into develop
fea5e97
@backflip
Merge branch 'feature/dev-js' into develop
90bd71c
@backflip
[Fix] estatico-boilerplate: Fixed path in moved dev.js
53a71ae
@backflip
[Change] estatico-boilerplate: Removed jQuery
7667566
@backflip
[Change] estatico-boilerplate: Reverted changes unrelated to jQuery r…
0e6c2b9 
…emoval
@backflip
[Change] estatico-boilerplate: Reverted changes unrelatedto jQuery re…
35d133e 
…moval (2)
@backflip
[Fix] estatico-boilerplate: Expose module uuid instead of instance du…
c36ee0c 
…e to limitations of dataset
@backflip
[Change] Added estatico-jest to replace QUnit test setup in estatico-…
2bc82a6 
…boilerplate
@backflip
[Fix] estatico-boilerplate: Fixed js:test logging / exiting
b79855a
@backflip
[Docs] estatico-jest: Added instructions to set up gulp task
e9ed8e6
@backflip backflip mentioned this pull request Sep 18, 2018
Merged
@backflip
Copy link
Collaborator Author

backflip commented Sep 19, 2018 •
edited
Loading

Remaining problem: The test runner quits the main test process when running on Travis CI:
image

This is not happening locally. 🤔

UPDATE: Fixed via resetting stdio config when in CI env

@backflip backflip changed the base branch from feature/drop-jquery to develop September 19, 2018 16:00
@backflip backflip merged commit c25c2f4 into develop Sep 19, 2018
@robinloeffel robinloeffel deleted the feature/jest branch January 20, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orioltf orioltf orioltf approved these changes

@marbor3 marbor3 Awaiting requested review from marbor3

@christiansany christiansany Awaiting requested review from christiansany

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backflip @orioltf