Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Yarn #12

Closed
backflip opened this issue Nov 1, 2016 · 5 comments
Closed

Evaluate Yarn #12

backflip opened this issue Nov 1, 2016 · 5 comments

Comments

@backflip
Copy link
Collaborator

backflip commented Nov 1, 2016 •
edited
Loading

Because speed (2-4x faster without a node_modules folder (depending on whether there is a local cache or not), 30x faster with a preexisting one – tested locally and on Jenkins) and reliability (.yarn.lock vs npm-shrinkwrap.json).
@backflip
Copy link
Collaborator Author

backflip commented Nov 1, 2016 •
edited
Loading

https://github.com/unic/estatico/compare/feature/ESTATICO-224-yarn?expand=1

@backflip
Copy link
Collaborator Author

backflip commented Nov 2, 2016 •
edited
Loading

Issue: gulp-raster seems not to be resolved correctly.

"gulp-raster@git://github.com/unic/gulp-raster.git#acd044d950d9ed65870b3c39cb6294a09174d166":
  version "0.1.0"
  resolved "git://github.com/unic/gulp-raster.git#acd044d950d9ed65870b3c39cb6294a09174d166"
  dependencies:
    gulp-util "~2.2.14"
    phridge "~1.1.0"
    through2 "*"

phridge should resolve to ^2.0.0: unic/gulp-raster@acd044d

See yarnpkg/yarn#1393 (comment)

@backflip
Copy link
Collaborator Author

backflip commented Nov 2, 2016

Update: Tags seem to work: fd37dab

@orioltf orioltf mentioned this issue Jan 25, 2017
Closed
orioltf pushed a commit that referenced this issue Mar 8, 2017
Merge pull request #12 in BUDC/concorel-frontend from feature/CONCORE…
a237787 
…L-94-c_03-intro-copy-module-tasks to develop

* commit '36e2999d7e79ea47e66e15a21b52eee3657c4c1b':
  Reduntant variable deleted
  More variants for intro copy
  Linting problem fixed (spacing)
  COnCOREL-94 CodeReview fixes, fonts styling
  Font weight changed into variable
  CONCOREL-94 Border width, paddings, container sizing
  Styling
  Intro styling
  CONCOREL-94 Intro copy basic structure
@orioltf
Copy link
Member

orioltf commented May 12, 2017

PR awaiting feedback or reviews: #67

@backflip backflip mentioned this issue Jun 13, 2017
Closed
@backflip
Copy link
Collaborator Author

Dropped since recent npm versions fixed all of our issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@backflip @orioltf