Allow to set up project with docker compose up #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdinicola
reviewed
Mar 19, 2024
|
|
||
| services: | ||
| proxy: | ||
| image: tivix/docker-nginx:v17 |
There was a problem hiding this comment.
why do we need this custom nginx?
There was a problem hiding this comment.
this is for local dev setup, so we can serve statics properly via docker volume
chose this one because it's a simple wrapper that allows to configure exactly what is needed for inter-service communication with some sane defaults - upstreams, statics, etc.
domdinicola
reviewed
Mar 20, 2024
| @@ -1,34 +0,0 @@ | |||
| [circus] | |||
There was a problem hiding this comment.
we may need to keep circus since everything here is running within the same container @wozniakpl
|
will not be implemented since we're keeping all in one image |
|
I think here we are using circus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.