Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STG] Payment Plan export xlsx: added FSP template doc types list #4508

Merged

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Dec 6, 2024

AB#225873: Armenia-Addition of document "social security number" to the FSP file format fields

Screenshot 2024-12-06 at 2 37 49 PM

Screenshot 2024-12-06 at 2 09 02 PM

@pavlo-mk pavlo-mk added payment module backend Changes in BE code labels Dec 6, 2024
@pavlo-mk pavlo-mk self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (bc03fd0) to head (1e88adc).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...t/xlsx/xlsx_payment_plan_export_per_fsp_service.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #4508      +/-   ##
===========================================
- Coverage    84.71%   84.65%   -0.06%     
===========================================
  Files          507      508       +1     
  Lines        36371    36224     -147     
===========================================
- Hits         30810    30665     -145     
+ Misses        5561     5559       -2     
Flag Coverage Δ
e2e 62.58% <82.60%> (-0.12%) ⬇️
unittests 82.89% <95.65%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk enabled auto-merge (squash) December 6, 2024 14:06
@pavlo-mk pavlo-mk merged commit eb08987 into staging Dec 6, 2024
13 checks passed
@pavlo-mk pavlo-mk deleted the stg_payment_plan_export_xlsx_add_fsp_template_doc_types branch December 6, 2024 14:19
pavlo-mk added a commit that referenced this pull request Dec 9, 2024
* STG //  Fix RDI import dmd json field (#4504)

* fix rdi import dmd data json

* add migration

* fix test

* imports

* more fixes

* remove generateroles from upgrade, update generateroles based on admin history for these roles

* [STG] Payment Plan export xlsx: added FSP template doc types list (#4508)

* upd get_column_value_from_payment & fsp template doc types

* document_types ⭐

* fix 🌟

---------

Co-authored-by: Domenico <dom.dinicola@gmail.com>
Co-authored-by: Paulina Kujawa <p.kujawa2f@gmail.com>
Co-authored-by: Paulina Kujawa <42150286+pkujawa@users.noreply.github.com>
pavlo-mk added a commit that referenced this pull request Dec 23, 2024
* skip unstable

* STG //  Fix RDI import dmd json field (#4504)

* fix rdi import dmd data json

* add migration

* fix test

* imports

* more fixes

* remove generateroles from upgrade, update generateroles based on admin history for these roles

* [STG] Payment Plan export xlsx: added FSP template doc types list (#4508)

* upd get_column_value_from_payment & fsp template doc types

* document_types ⭐

* fix 🌟

* Dashboard fix

* 215787_drop_cash_assist_migration_script_fix (#4509)

* 2226242_Payment_verification_page_not_accessible (#4514)

* rollback generateroles to upgrade, skip updating existing roles

* Back merge PROD > STG (#4516)

* skip unstable

* 2226242_Payment_verification_page_not_accessible (#4514)

---------

Co-authored-by: Jan Romaniak <jan.romaniak@tivix.com>
Co-authored-by: Marek Biczysko <34810846+MarekBiczysko@users.noreply.github.com>

* add correct permission for cycles page

* fe fix

* just new line

* Master into stg (#4534)

* AB#226656 Error Cannot read properties of undefined Grievance ticket

* Fixes to managers for migretable models

* added unicef id

* fix frontend lint

* unique unicef_id constraint

* fix test_double_entries

* fix household test_models

* change exclusion for importing hh and inds to another program

* fix test_create_pending_objects_from_objects

* fix linters

* fix test_create_targeting_for_people

* add models for new constraints

* fix test

* remove one time scripts which are not valid with new contraint

* fixed format

* change unique name

* fixed tests

* fix more tests

* fix laast e2e tests

---------

Co-authored-by: Jan Romaniak <jan.romaniak@kellton.com>
Co-authored-by: Jan Romaniak <jan.romaniak@tivix.com>
Co-authored-by: Paulina Kujawa <42150286+pkujawa@users.noreply.github.com>
Co-authored-by: Paulina Kujawa <p.kujawa2f@gmail.com>

* fix test & migration

---------

Co-authored-by: Jan Romaniak <jan.romaniak@tivix.com>
Co-authored-by: Domenico <dom.dinicola@gmail.com>
Co-authored-by: Paulina Kujawa <p.kujawa2f@gmail.com>
Co-authored-by: Paulina Kujawa <42150286+pkujawa@users.noreply.github.com>
Co-authored-by: Allan Stockman Rugano <kuristockyrugano@gmail.com>
Co-authored-by: Marek Biczysko <34810846+MarekBiczysko@users.noreply.github.com>
Co-authored-by: Allan Stockman RUGANO <srugano@users.noreply.github.com>
Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>
Co-authored-by: Jan Romaniak <jan.romaniak@kellton.com>
pavlo-mk added a commit that referenced this pull request Dec 24, 2024
* skip unstable

* STG //  Fix RDI import dmd json field (#4504)

* fix rdi import dmd data json

* add migration

* fix test

* imports

* more fixes

* remove generateroles from upgrade, update generateroles based on admin history for these roles

* [STG] Payment Plan export xlsx: added FSP template doc types list (#4508)

* upd get_column_value_from_payment & fsp template doc types

* document_types ⭐

* fix 🌟

* Dashboard fix

* 215787_drop_cash_assist_migration_script_fix (#4509)

* 2226242_Payment_verification_page_not_accessible (#4514)

* add correct permission for cycles page

* fe fix

* just new line

* AB#226656 Error Cannot read properties of undefined Grievance ticket

* change to use replica db

* fix tests

---------

Co-authored-by: pavlo-mk <pv.pasha.pv@gmail.com>
Co-authored-by: Domenico <dom.dinicola@gmail.com>
Co-authored-by: Paulina Kujawa <p.kujawa2f@gmail.com>
Co-authored-by: Paulina Kujawa <42150286+pkujawa@users.noreply.github.com>
Co-authored-by: Allan Stockman Rugano <kuristockyrugano@gmail.com>
Co-authored-by: Marek Biczysko <34810846+MarekBiczysko@users.noreply.github.com>
Co-authored-by: Allan Stockman RUGANO <srugano@users.noreply.github.com>
Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code payment module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants