Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to managers for mergable models #4528

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Dec 18, 2024

This pull request includes several changes aimed at improving the handling of merge status objects in the household schema and permissions. The most important changes include modifications to the get_node method, updates to various resolve methods to use all_merge_status_objects, and adjustments to the SoftDeletableRepresentationMergeStatusModel.

Improvements to handling merge status objects:

Adjustments to model managers:

  • src/hct_mis_api/apps/utils/models.py: Changed the SoftDeletableRepresentationMergeStatusModel to use SoftDeletableRepresentationMergedManager for the objects manager, ensuring proper filtering by rdi_merge_status.

Minor changes:

@johniak johniak changed the title Fixes to managers for migretable models Fixes to managers for mergable models Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (62c8f66) to head (386b269).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4528   +/-   ##
=======================================
  Coverage   84.65%   84.66%           
=======================================
  Files         508      508           
  Lines       36224    36232    +8     
=======================================
+ Hits        30667    30675    +8     
  Misses       5557     5557           
Flag Coverage Δ
e2e 62.62% <100.00%> (+0.05%) ⬆️
unittests 82.90% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkujawa pkujawa merged commit 2430469 into master Dec 18, 2024
13 checks passed
@pkujawa pkujawa deleted the hotfix/use-good-household-manager branch December 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants