Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean logging and sentry logging setup #4611

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Feb 4, 2025

This pull request includes several changes to improve the logging level across various functions in the codebase. The primary change involves replacing logger.exception and logger.error with logger.warning to adjust the severity of the logged messages.

Changes to logging levels:

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 31.88406% with 94 lines in your changes missing coverage. Please review.

Project coverage is 86.13%. Comparing base (8714fb0) to head (207339c).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/hct_mis_api/apps/core/services/rapid_pro/api.py 0.00% 6 Missing ⚠️
src/hct_mis_api/apps/payment/mutations.py 14.28% 6 Missing ⚠️
src/hct_mis_api/apps/core/kobo/api.py 0.00% 5 Missing ⚠️
src/hct_mis_api/apps/account/microsoft_graph.py 0.00% 4 Missing ⚠️
..._mis_api/apps/accountability/services/verifiers.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/core/countries.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/core/schema.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/registration_data/admin.py 0.00% 4 Missing ⚠️
src/hct_mis_api/apps/account/admin/ad.py 0.00% 3 Missing ⚠️
src/hct_mis_api/apps/account/admin/mixins.py 50.00% 3 Missing ⚠️
... and 35 more

❌ Your patch check has failed because the patch coverage (31.88%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4611   +/-   ##
========================================
  Coverage    86.13%   86.13%           
========================================
  Files          566      566           
  Lines        36815    36815           
========================================
  Hits         31711    31711           
  Misses        5104     5104           
Flag Coverage Δ
e2e 60.29% <0.00%> (-0.02%) ⬇️
unittests 84.65% <31.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	src/hct_mis_api/apps/payment/services/payment_gateway.py
#	src/hct_mis_api/apps/targeting/validators.py
#	src/hct_mis_api/one_time_scripts/migrate_rdi_deduplication_stats.py
@@ -0,0 +1,67 @@
import logging

from hct_mis_api.apps.household.models import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like some merge bring me that, I will remove it from my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants