💄 fix: Added shortcodes for CAUTION and IMPORTANT admonition

[BeeBombshell]

Fixes #64 and #66

Changes:

The PR adds shortcodes for CAUTION and IMPORTANT admonition blocks.

Screenshot of the change:

To test if the new admonitions are properly working, the following code can be used:

{{< notice important >}}
  This is a simple important.
{{</ notice >}}

{{< notice caution >}}
  This is a simple caution.
{{</ notice >}}

[BeeBombshell]

@jwflory, Kindly review and suggest if there are any changes that need to be added. 😊

[Neha9849]

@BeeBombshell that looks great!!
Currently we are using only one icon for all admonition blocks, I would suggest changing the icons in accordance with the admonition for to enhance user experience.
I would also suggest adding demo of this shortcodes in the elements page as added for other admonitions, so that it would be helpful for others.
@jwflory what do you think?

[BeeBombshell]

Thanks, @Neha9849 I think that's a good suggestion!
If you and @jwflory approve, then I can go ahead and either create a new issue for the above-mentioned changes (demo + icons) or add commits to the same PR. 😄

[jwflory]

@BeeBombshell wrote…
The PR adds shortcodes for CAUTION and IMPORTANT admonition blocks.

Thanks, this change is looking good. It adds support for the admonitions built into Asciidoc, but these shortcodes can be used in both Markdown and Asciidoc content. 🙌🏻

@Neha9849 wrote…
Currently we are using only one icon for all admonition blocks, I would suggest changing the icons in accordance with the admonition for to enhance user experience.

@BeeBombshell wrote…
I can go ahead and either create a new issue for the above-mentioned changes (demo + icons) or add commits to the same PR. smile

+1. We can use @Yavnikaa's mockup she designed here in #64 as a reference. She also found an open source icon set we could use, Feather Icons, for logos.

The best approach here will be to add commits to the same PR. Since the design prep is done, we can go straight to implementation. This Pull Request can become a general rework of admonitions across the theme.

@Neha9849 wrote…
I would also suggest adding demo of this shortcodes in the elements page as added for other admonitions, so that it would be helpful for others.

This was also my other piece of feedback. More docs 😀 We can document the new admonitions by adding an example in the Elements page.

[BeeBombshell]

Hi @jwflory, I was going through the project and I found out that the project is already using the Themify Icons Set. So I tried to incorporate these icons into the admonition shortcodes. Kindly take a look and share your reviews! 😄

[jwflory]

@BeeBombshell Looks great 👍🏻 Please push up your code and I will move the review forward 🙌🏻

[BeeBombshell]

@jwflory I've added the above-mentioned changes. Kindly review... 😄

[BeeBombshell]

@jwflory I revoked the changes that were accidentally made. Please take a look! ☺️

[jwflory]

Thanks, @BeeBombshell, this looks good! I pushed a new commit to remove some of the other changes made by the IDE. But I cloned this locally and the new admonitions look great. Nice work! 🚀

Merging. 🎬