-
Notifications
You must be signed in to change notification settings - Fork 8
Update Main Branch #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Victor1Ja
wants to merge
100
commits into
main
Choose a base branch
from
prod
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+15,900
−13,959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify NotFound Page to give message when the school it is not register.
Instead of move the initiate from app to home , set the default scheduledTesting to false, and only set it true when start with propper school and set a proper school.
Also Move the code to make home.page.tx more clean
checkRightGigaIdSlow is not the propper way for getting the right gigaID but works as diference as checkRightGigaId
Also add Spanish translation for the home page
Changed mostly all the text with [traslate]="key"
Modified the header to show the FAQs on all pages\n added keys to start test and to app Menu
* move appName and appNameSuffix to environment config * update * add variable for about menu * use uppercase
…info (#15) * build: Add build:electron-publish script for Electron app * Fix: Fix failover in access network info The previous method was not reliable and failing when rate limit on ipinfo, changed so when it fails request the net info from ipv4. * refactor: Improve error handling in MlabService findServer method ---------
Co-authored-by: Victor Lopez <viclopez@unicef.com>
Add measurement on startup at the next 15min
Release/1.0.9
Release/1.0.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Bug Fixes and Feature Enhancements
Description:
This pull request includes multiple commits that address various bug fixes and introduce new features to the codebase.
Changes Include:
.gitignore
file.giga_id
school.null
toundefined
in theset(schoolId)
function on the home page.removeUnregisterSchools
logic from the Home page.gigaID
.gigaID
.PCDC
version in the Electronpackage.json
file.checkRightGigaId
function to obtain the correctgigaID
.getTime
.ndt7
values into the measurement schema.UploadService
andMeasurementClientService
.1.0.9
.appName
andappNameSuffix
to environment configurations.MeasurementClientService
.build:electron-publish
script and fixing failover in network access information retrieval.MlabService
findServer
method.ScheduleService
to enhance startup test scheduling and logging.MlabService
to return cached answers if available.MlabService
.1.0.10
.environment.ts
.getNetInfo
method.NetworkService
.UploadService
.NetworkService
to include ASN information inIpInfoData
.Request for Review:
Please review these changes and merge them into the main branch. Let me know if any further modifications are needed.