Conversation
- Add isNametagAvailable method to NametagService - Implement checkNametagAvailability in useWallet hook - Validate nametag availability before minting in CreateWalletFlow - Add input validation to allow only Latin letters, numbers, and special chars (_, -, +, .) - Show error message if nametag already exists
Add nametag availability check and input validation
There was a problem hiding this comment.
Pull request overview
This PR introduces improvements to markdown parsing, nametag validation, and error handling in the wallet onboarding flow. The changes enhance user experience by adding support for markdown link tooltips, proper escape sequence handling, and real-time nametag availability checking.
Key changes:
- Enhanced markdown parser with escape sequence handling and tooltip support for links
- Added nametag availability checking before attempting to mint
- Implemented input validation to restrict nametag characters to allowed set
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/markdown.tsx | Added escape sequence processing, tooltip support for markdown links, and a helper function for splitting table rows while respecting quoted strings |
| src/components/wallet/L3/services/NametagService.ts | Added isNametagAvailable method to check if a nametag has already been minted |
| src/components/wallet/L3/onboarding/CreateWalletFlow.tsx | Added nametag availability check before minting and input validation to restrict characters |
| src/components/wallet/L3/hooks/useWallet.ts | Added checkNametagAvailability wrapper function and exposed it in the hook's return value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Automatically convert uppercase letters to lowercase in nametag input field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.