fix: resolve existing nametag before prompting on new address creation#210
Merged
fix: resolve existing nametag before prompting on new address creation#210
Conversation
When creating a new address, first call switchToAddress to create and switch, then check if SDK recovered a nametag from Nostr. Only show the nametag input modal if no existing nametag was found. - handleNewClick: create address first, check identity.nametag, skip modal if exists - handleCreateWithNametag: use registerNametag on current address - handleCreateWithoutNametag: simplified (address already created) - useCreateAddress: same flow — skip to complete if nametag recovered Requires sphere-sdk change: switchToAddress now calls syncIdentityWithTransport for all addresses (not just those with local nametag), enabling nametag recovery via transport.resolve(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.