Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17227 CLDR 45 finalcharts #131

Merged
merged 4 commits into from
Apr 17, 2024
Merged

CLDR-17227 CLDR 45 finalcharts #131

merged 4 commits into from
Apr 17, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 16, 2024

  • Removes the 'beta' tag from charts!
Checklist

@srl295 srl295 self-assigned this Apr 16, 2024
@srl295 srl295 marked this pull request as draft April 16, 2024 13:42
@srl295
Copy link
Member Author

srl295 commented Apr 16, 2024

Something's wrong with the chart generation. GenerateAllCharts returns an error status at the end but doesn't generate all charts. So this may be incomplete.. investigating

@srl295 srl295 marked this pull request as ready for review April 16, 2024 19:59
Base automatically changed from CLDR-17539-cldr45-beta4-production-data to main April 16, 2024 19:59
@macchiati
Copy link
Member

GenerateAllCharts returns an error status at the end but doesn't generate all charts. So this may be incomplete.. investigating

Is this resolved? Do we know the problem?

@srl295
Copy link
Member Author

srl295 commented Apr 16, 2024

GenerateAllCharts returns an error status at the end but doesn't generate all charts. So this may be incomplete.. investigating

Is this resolved? Do we know the problem?

I think it was perhaps due to Java 21. Re-ran with Java 17 and it passed.

@macchiati
Copy link
Member

macchiati commented Apr 16, 2024 via email

@srl295 srl295 merged commit c702113 into main Apr 17, 2024
2 checks passed
@srl295 srl295 deleted the srl295/charts-45-beta4 branch April 17, 2024 01:08
@srl295
Copy link
Member Author

srl295 commented Apr 17, 2024

Hmmm. That blew up the number of files compared to your earlier versions.

Filed https://unicode-org.atlassian.net/browse/CLDR-17552

It looks like the version is being included in a comment, which bypasses

the include file mechanism. That appears to be 'bout everything in

  • by_type

  • summary

Could you file a ticket to fix that, with a pointer to this PR?

On Tue, Apr 16, 2024 at 3:46 PM Steven R. Loomis @.***>

wrote:

GenerateAllCharts returns an error status at the end but doesn't generate

all charts. So this may be incomplete.. investigating

Is this resolved? Do we know the problem?

I think it was perhaps due to Java 21. Re-ran with Java 17 and it passed.

Reply to this email directly, view it on GitHub

#131 (comment),

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACJLEMAJ7JFG7ZPOQTIAG6DY5WS5JAVCNFSM6AAAAABGJLRD26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGAZTENRXGM

.

You are receiving this because your review was requested.Message ID:

@.***>

@macchiati
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants