Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-10560 change time cycle pref/use: CN: HH, TW: Bh, HK/MO: ah #1297

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Jun 3, 2021

CLDR-10560

  • This PR completes the ticket.

Change time cycle prefs for Chinese regions as described in the bug.

  1. CN (zh, yue_Hans; also bo, ii, ug) changes from ah to HH (and make that first preference for pattern char C)
  2. TW (zh_Hant) changes from ah to Bh. Affects standard formats, availableFormats, intervalFormats; the latter now have entries for greatestDifference="B".
  3. HK,MO continue to use ah (and make that first preference for pattern char C). Per further feedback (as noted in the ticket) there was no need to split HK,MO time cycle behavior by script.
  4. SG time cyle prefs are unchanged.
  5. zh_Hans_HK, zh_Hans_MO, zh_Hans_SG must now override the standard time formats inherited from zh (which have HH)
  6. zh_Hant_HK must now override standard time formats and 'h' formats inherited from zh_Hant (which have Bh)
  7. Note that supplemental timeData preferred value must be one of H, h, K, k

macchiati
macchiati previously approved these changes Jun 3, 2021
@pedberg-icu pedberg-icu force-pushed the CLDR-10560-Chinese-region-day-periods branch from 8c09072 to ed83beb Compare June 3, 2021 17:20
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu pedberg-icu requested a review from macchiati June 3, 2021 17:22
@pedberg-icu
Copy link
Contributor Author

Since the default time cycle was changing for CN, I also had to update bo, ii, ug; then I had to update bo_IN to add timeFormats with the original 12-hour cycle, to match default for IN.

@pedberg-icu pedberg-icu merged commit 0d53832 into unicode-org:master Jun 3, 2021
@pedberg-icu pedberg-icu deleted the CLDR-10560-Chinese-region-day-periods branch June 3, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants