-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-14717 json: fix repeat keys #1551
CLDR-14717 json: fix repeat keys #1551
Conversation
"dateFormats": {
"full": "EEEE, MMMM d, y G",
"full-datetimeSkeleton": "GyMMMMEEEEd",
"long": "MMMM d, y G",
"long-datetimeSkeleton": "GyMMMMd",
"medium": "MMM d, y G",
"medium-datetimeSkeleton": "GyMMMd",
"short": "M/d/y GGGGG",
"short-datetimeSkeleton": "GGGGGyMd"
}, Not a great solution, but avoids having to rewrite the output format. |
aaa9207
to
b563593
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
this draft PR now depends on #1552 |
d7287a9
to
f851145
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
63fc6ee
to
5c69562
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
This commit shows the effect of the change: |
- use JsonObject instead of JsonWriter, using pseudo-jsonpath - exclude <language type="root"/> explicitly from bcp47-strict output - remove grammaticalGenderFeatures.json it's now folded (back) into grammaticalFeatures.json (where it belongs)
5c69562
to
86d5d20
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Rewrite output section completely to avoid dups
<language type="root"/>
explicitly from bcp47-strict outputit's now folded (back) into grammaticalFeatures.json (where it belongs)
CLDR-14717