-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-15113 json: move datetimeSkeleton to a parallel location #1558
CLDR-15113 json: move datetimeSkeleton to a parallel location #1558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was proposing
dateFormats: {...}
dateSkeletons: {...}
Which also leads to the corresponding:
timeFormats: {...}
timeSkeletons: {...}
It is a bit hard to see what your code is producing, so can you check to see that it matches the above?
@macchiati What I produce is in the head comment above, since |
- dateSkeletons and timeSkeletons are now siblings to dateFormats and timeFormats
a07958a
to
72536cc
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
actually i missed the timeSkeletons before. @macchiati as of 72536cc the output is now: "dateFormats": {
"full": "EEEE, MMMM d, y",
"long": "MMMM d, y",
"medium": "MMM d, y",
"short": "M/d/yy"
},
"dateSkeletons": {
"full": "yMMMMEEEEd",
"long": "yMMMMd",
"medium": "yMMMd",
"short": "yyMd"
},
"timeFormats": {
"full": "h:mm:ss a zzzz",
"long": "h:mm:ss a z",
"medium": "h:mm:ss a",
"short": "h:mm a"
},
"timeSkeletons": {
"full": "ahmmsszzzz",
"long": "ahmmssz",
"medium": "ahmmss",
"short": "ahmm"
}, |
@macchiati this is the full diff for output files: (i skipped changing the version this time) unicode-org/cldr-json@a18f696 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
CLDR-15113
Change from the previous stopgap format in #1552 to:
@macchiati this is slightly different than your proposal in #1552 (comment) - I made the object name
datetimeSkeleton
to match the actual element name in CLDR, and the structure would allow atimeSkeleton
etc if such was needed.