CLDR-15948 Add additional well-formedness clauses #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
force-pushed
the
CLDR-15948-macchiati-well-formed
branch
from
fff8c2c
to
08025e1
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
pedberg-icu
reviewed
Nov 19, 2024
| @@ -4310,65 +4348,18 @@ Other contributors to CLDR are listed on the [CLDR Project Page](https://www.uni | |||
|
|
|||
| ## <a name="Modifications" href="#Modifications">Modifications</a> | |||
|
|
|||
| **Changes in LDML Version 47 (Differences from Version 46.1)** | |||
There was a problem hiding this comment.
Was not really necessary to delete this, it is not in the maint branch version of the spec which is what we are actually using for 46.1, and it might be useful to distinguish 47 changes when we start adding them... but we can add it back later.
pedberg-icu
approved these changes
Nov 19, 2024
|
I just realized that we should change the version to 46.1 (draft) until
46.1 releases, so that
https://unicode.org/reports/tr35/dev/tr35.html#Contents works correctly.
…On Tue, Nov 19, 2024 at 9:01 AM Peter Edberg ***@***.***> wrote:
***@***.**** approved this pull request.
Lots of good cleanup, thanks. Nice to distinguish well-formed from valid.
—
Reply to this email directly, view it on GitHub
<#4205 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMGJ5BJRQ25KBCUEAV32BNVGZAVCNFSM6AAAAABSA7Q23CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBWGA4DGOJVGQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Shouldn’t we just change to have the dev document generated from the maint/maint-46 branch (which already has the correct versions etc.)? - Peter
… On Nov 19, 2024, at 10:40 AM, Mark Davis ***@***.***> wrote:
I just realized that we should change the version to 46.1 (draft) until
46.1 releases, so that
https://unicode.org/reports/tr35/dev/tr35.html#Contents works correctly.
On Tue, Nov 19, 2024 at 9:01 AM Peter Edberg ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Lots of good cleanup, thanks. Nice to distinguish well-formed from valid.
>
> —
> Reply to this email directly, view it on GitHub
> <#4205 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACJLEMGJ5BJRQ25KBCUEAV32BNVGZAVCNFSM6AAAAABSA7Q23CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBWGA4DGOJVGQ>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub <#4205 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBS4KEDSH4PBXLSZFT5FOD2BOA3VAVCNFSM6AAAAABSA7Q23CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGQ3TEOBQGQ>.
You are receiving this because your review was requested.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-15948
We need better well-formedness clauses for identifiers, for references. This doesn't make material changes, since (with some work) someone can derived that the various identifiers have those restrictions. Also added links to some of the EBNF for locale ids, for reference, and reversed the aliasing for keyword, key, type to be the more understandable (and parallel to -t-) terms.
Removed the quotes around the identifiers in the large table, since that was confusing to readers, replacing with
codestyle.ALLOW_MANY_COMMITS=true