Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18117 Update subdivisionData.txt to correct province name Afyon to Afyonkarahisar #4206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-akbay
Copy link

@m-akbay m-akbay commented Nov 19, 2024

…ahisar

CLDR-_____

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@conradarcturus conradarcturus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing the change. Can you file a ticket so we can make sure this goes through the official review process? https://cldr.unicode.org/requesting_changes#how-to-file-a-ticket

Then once you have a ticket number, update this PR.

I'll also note that it looks like the official name is Afyonkarahisar but Wikipedia notes in common usage it can also be Afyon. CLDR is meant to reflect common usage. Please add more context and attach links to Turkish media indicating the best name for this province.

@m-akbay m-akbay changed the title Update subdivisionData.txt to correct province name Afyon to Afyonkarahisar CLDR-18117: Update subdivisionData.txt to correct province name Afyon to Afyonkarahisar Nov 20, 2024
@m-akbay m-akbay changed the title CLDR-18117: Update subdivisionData.txt to correct province name Afyon to Afyonkarahisar CLDR-18117 Update subdivisionData.txt to correct province name Afyon to Afyonkarahisar Nov 20, 2024
@m-akbay
Copy link
Author

m-akbay commented Nov 20, 2024

The current name for the province "Afyon" in subdivisionData.txt is outdated and incomplete. The official and full name of the province, as recognized in Turkish law and administrative records, is "Afyonkarahisar". This name has been in official use since 2005, following a decision to restore the historical name of the city and province.

Reason for the Update:

Consistency with Official Standards: The Turkish government and international organizations recognize the name "Afyonkarahisar" as the official designation.

Alignment with CLDR Goals: CLDR aims to provide accurate and standardized data for localization. Using the official and complete name ensures consistency and reliability in localized applications.

Avoiding Ambiguity: "Afyon" is commonly used informally, but it is not the formal or legal name. Updating the entry eliminates potential confusion for developers and end-users.

Additional Note: In the CLDR repository, all other references to this province already use the name "Afyonkarahisar". This update to subdivisionData.txt will align it with the rest of the repository, ensuring uniformity across all files and data points.

Proposed Solution:

Update the subdivision name from "Afyon" to "Afyonkarahisar" in subdivisionData.txt.

Optionally, retain "Afyon" as an alias or alternative name for backward compatibility or informal usage contexts.

This change will align CLDR with international and national standards for geographic names, improve data accuracy, and ensure consistency across the entire repository.

https://www.afyonkarahisar.gov.tr/
https://www.hurriyet.com.tr/afyonkarahisar-haberleri/
https://www.sabah.com.tr/afyonkarahisar

Copy link
Contributor

@conradarcturus conradarcturus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough response! Looks great. We just need to wait for the ticket to be accepted before we can merge the change.

@conradarcturus
Copy link
Contributor

Unfortunately we'll have to wait until 2025 to land this change -- it needs discussion in the Unicode CLDR committees on the protocol to address issues in subdivision data.

Thanks for your patience. It brought up a good issue -- but too good so it needs a broader discussion.

@m-akbay
Copy link
Author

m-akbay commented Dec 5, 2024

No worries, no rush :) Take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants