Skip to content

CLDR-18292 quell noisy tests #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -38,8 +38,6 @@
import org.unicode.cldr.util.props.ICUPropertyFactory;

public class TestHelper extends TestFmwkPlus {
public static boolean DEBUG = true;

private static final UnicodeSet DIGITS = new UnicodeSet("[0-9]");
static CLDRConfig testInfo = CLDRConfig.getInstance();
private static final SupplementalDataInfo SUPPLEMENTAL_DATA_INFO =
@@ -596,12 +594,10 @@ private void verifyRequiredVotes(
ph = PathHeader.getFactory(testInfo.getEnglish()).fromPath(xpath);
}
resolver.setLocale(CLDRLocale.getInstance(locale), ph);
if (!assertEquals(
assertEquals(
locale + " verifyRequiredVotes: " + ph.toString(),
required,
resolver.getRequiredVotes())) {
int debug = 0;
}
resolver.getRequiredVotes());
}

public void TestRequiredVotes() {
@@ -1477,6 +1473,8 @@ public void TestMissingStatus() {

/** Check that expected paths are Aliased, and have debugging code */
public void TestMissingGrammar() {
final boolean DEBUG = true; // TODO CLDR-18524 What's the purpose of this flag?

// https://cldr-smoke.unicode.org/cldr-apps/v#/hu/Length/a4915bf505ffb49
final String path =
"//ldml/units/unitLength[@type=\"long\"]/unit[@type=\"length-meter\"]/unitPattern[@count=\"one\"][@case=\"accusative\"]";
@@ -1544,6 +1542,12 @@ public void checkGrammarCoverage(
assertEquals(locale + " missingCounter (2)", sizes[2], missingCounter.getTotal());
assertEquals(locale + " missingPaths (3)", sizes[3], missingPaths.size());
assertEquals(locale + " unconfirmedPaths (4)", sizes[4], unconfirmedPaths.size());

// showStatusResults does not throw any errors, so skip it as a known issue
if (logKnownIssue("CLDR-18524", "showStatusResults() produces thousands of warnings")) {
return;
}

showStatusResults(
locale,
foundCounter,
@@ -1574,6 +1578,11 @@ public void checkGrammarCoverage(
missingCounter,
missingPaths,
unconfirmedPaths);
} else {
// !debug
if (!logKnownIssue("CLDR-18524", "DEBUG is false - remove the debug flag from tests")) {
return;
}
}
}


Unchanged files with check annotations Beta

if (!metadataScripts.isEmpty()) {
// Warning, not error, so that we can add scripts to the script metadata
// and later update to the Unicode version that has characters for those scripts.
warnln("Script Metadata for characters not in Unicode: " + metadataScripts);

Check warning on line 329 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java

GitHub Actions / build

(LikelySubtagsTest.java:329) Warning: Script Metadata for characters not in Unicode: [Berf, Chis, Sidt, Tayo, Tols]
}
}
}
if (!collectedBad.isEmpty()) {
warnln(

Check warning on line 536 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java

GitHub Actions / build

(LikelySubtagsTest.java:536) Warning: Locales have 224 unexpected characters in main and/or aux: [҂״܀-܍०-९৲-৺੦-੯૰౦-౯໐-໙၀-၉၏႐-႙႞႟፠-፼᎐-᎙᠐-᠙⳥-⳪꒐-꓆𞅏{a\:}{ch’}{e\:}{i\:}{k’}{n\-}{o\:}{q’}{s\-c}{ts’}{tz’}{tł’}{t’}{à\:}{á\:}{è\:}{é\:}{ì\:}{í\:}{ò\:}{ó\:}{ଅ\:}{ଆ\:}{ଏ\:}]
"Locales have "
+ collectedBad.size()
+ " unexpected characters in main and/or aux:\t"
if (logKnownIssue("CLDR-16394", "slightly out of order")) {
errorType = WARN;
}
msg(

Check warning on line 449 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAnnotations.java

GitHub Actions / build

(TestAnnotations.java:449) Warning: Out of order: 🧔‍♀ (57700) woman: beard > 👩 (61200) woman

Check warning on line 449 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAnnotations.java

GitHub Actions / build

(TestAnnotations.java:449) Warning: Out of order: 👱‍♀ (66700) woman: blond hair > 👱‍♂ (67900) man: blond hair

Check warning on line 449 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAnnotations.java

GitHub Actions / build

(TestAnnotations.java:449) Warning: Out of order: 🫆 (347500) fingerprint > 🏻 (347600) light skin tone
"Out of order: "
+ lastEmoji
+ " ("
void show(DtdType dtdType, boolean verbose, ImmutableSet<ValueStatus> retain) {
if (dtdData.dtdType == DtdType.keyboard3
&& testLog.logKnownIssue("CLDR-14974", "skipping for keyboard")) {
testLog.warnln("keyboard3 is missing validity checks");

Check warning on line 312 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java

GitHub Actions / build

(TestAttributeValues.java:312) Warning: keyboard3 is missing validity checks
}
boolean haveProblems = false;
for (ValueStatus valueStatus : ValueStatus.values()) {
if (keyTrans != null) {
engKey = keyAlias;
foundEnglish.put(engKey, "", keyTrans);
warnln(

Check warning on line 103 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestBCP47.java

GitHub Actions / build

(TestBCP47.java:103) Warning: Type for English 'key' translation is calendar, while bcp47 is ca

Check warning on line 103 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestBCP47.java

GitHub Actions / build

(TestBCP47.java:103) Warning: Type for English 'key' translation is collation, while bcp47 is co
"Type for English 'key' translation is "
+ engKey
+ ", while bcp47 is "
if (trans != null) {
engType = typeAlias;
foundEnglish.put(engKey, engType, trans);
warnln(

Check warning on line 211 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestBCP47.java

GitHub Actions / build

(TestBCP47.java:211) Warning: Type for English 'key+type' translation is calendar+ethiopic-amete-alem, while bcp47 is ca+ethioaa

Check warning on line 211 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestBCP47.java

GitHub Actions / build

(TestBCP47.java:211) Warning: Type for English 'key+type' translation is calendar+gregorian, while bcp47 is ca+gregory
"Type for English 'key+type' translation is "
+ engKey
+ "+"