Skip to content

Conversation

@Yqwed
Copy link
Contributor

@Yqwed Yqwed commented Apr 9, 2025

No description provided.

Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generated from the unmerged CLDR PR?

"America:Virgin"{"America/St_Thomas"}
"America:Yellowknife"{"America/Edmonton"}
"Antarctica:South_Pole"{"Pacific/Auckland"}
"Antarctica:South_Pole"{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is bad, did you pull in unicode-org/cldr#4592?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4592 was merged 12 hours ago, so nope. Let me sync my CLDR checkout.

Thank you for pointing that out.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tzdata/icunew/2025b/44/be/timezoneTypes.res is different
  • tzdata/icunew/2025b/44/ee/timezoneTypes.res is different
  • tzdata/icunew/2025b/44/le/timezoneTypes.res is different
  • tzdata/icunew/2025b/44/timezoneTypes.txt is different
  • tzdata/icunew/2025b/44/zoneinfo64.txt is different
  • tzdata/supplemental/timezoneTypes.txt is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Yqwed
Copy link
Contributor Author

Yqwed commented Apr 9, 2025

Is this generated from the unmerged CLDR PR?

Yes, this is generated with unicode-org/cldr#4593.

Copy link
Member

@yumaoka yumaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richgillam richgillam merged commit 85b3c65 into unicode-org:main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants