ICU-20250 faster to make a property set #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markusicu
commented
Nov 11, 2018
•
markusicu
commented
- Issue filed: https://unicode-org.atlassian.net/browse/ICU-20250
- Updated PR title and link in previous line to include Issue number
- Issue accepted
- Tests included
- Documentation is changed or added
|
Confirmed that the changes make UnicodeSet construction faster for number formatting code. |
aheninger
previously approved these changes
Nov 12, 2018
- fastpath for UnicodeSet.add(new last range) - fewer UnicodeSet memory allocations: initial internal list array, exponential array growth, allocate strings list/set only when first one is added - faster CodePointTrie.getRange(): fewer calls to filter function - revert UnicodeSet(intprop=value) from trie ranges to range starts + lookup - cache per-int-prop range starts: fewer lookups
markusicu
force-pushed
the
fastpropset
branch
from
d2864ad to
7f07002
Compare
aheninger
approved these changes
Nov 13, 2018
BoredOutOfMyGit
pushed a commit
to codeaurora-unofficial/platform-external-icu
that referenced
this pull request
Nov 20, 2018
Url: unicode-org/icu@98f9170 github pull request: unicode-org/icu#278 Changes: - fastpath for UnicodeSet.add(new last range) - fewer UnicodeSet memory allocations: initial internal list array, exponential array growth, allocate strings list/set only when first one is added - faster CodePointTrie.getRange(): fewer calls to filter function - revert UnicodeSet(intprop=value) from trie ranges to range starts + lookup - cache per-int-prop range starts: fewer lookups Bug: 119388329 Test: CtsIcuTestCases Change-Id: I75b87d4574c183a171b0743a14f156f02cdcc43e
mapx
pushed a commit
to mapx/icu
that referenced
this pull request
Dec 11, 2018
Cherry-pick another upstream patch to improve the performance of UnicodeSet. unicode-org/icu#278 Bug: 899983,901532 Test: Android webview start-up perf and Windows perf graph Change-Id: I2c2a22a398883178734a2c2a6c5975d9551b039e TBR=ftang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1335799 Reviewed-by: Jungshik Shin <jshin@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.