Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22942 MF2 ICU4C: NFC-normalize names and keys according to spec #3239

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Oct 10, 2024

This PR adds NFC normalization of variable names and .match keys, consistent with the spec change in unicode-org/message-format-wg#885.

The tests added by this PR are also in a PR against the spec repo, unicode-org/message-format-wg#904 , and can be removed once that PR lands and the ICU tests are updated from the spec repo.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22942
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism catamorphism marked this pull request as ready for review October 11, 2024 00:51
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism catamorphism requested a review from srl295 October 18, 2024 15:47
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, and good for getting the guards right.

Includes adding !UCONFIG_NO_NORMALIZATION guards to all MF2 files
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism catamorphism merged commit 0357501 into unicode-org:main Nov 6, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants