Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22954 disable TestCharString on Cygwin #3318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

markusicu
Copy link
Member

@markusicu markusicu commented Dec 23, 2024

See ICU-22999 for details

Disabled TestCharString.
Then TestCharStrAppendNumber crashed, so disabled that too.

Checklist

  • Required: Issue filed: ICU-22954
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@roubert roubert removed their assignment Dec 27, 2024
@roubert
Copy link
Member

roubert commented Dec 27, 2024

As the problem (whatever it might be) isn't in these tests, it just happens to manifest there, this shouldn't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants