Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22991 Simplified Grego code #3330

Merged
merged 1 commit into from
Jan 25, 2025
Merged

ICU-22991 Simplified Grego code #3330

merged 1 commit into from
Jan 25, 2025

Conversation

FrankYFTang
Copy link
Contributor

Use timeToFields instead of dayToFields if possible.

Checklist

  • Required: Issue filed: ICU-22991
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/chnsecal.cpp is now changed in the branch
  • icu4c/source/i18n/gregoimp.cpp is different
  • icu4c/source/i18n/gregoimp.h is now changed in the branch
  • icu4c/source/i18n/olsontz.cpp is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/gregoimp.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@richgillam richgillam self-assigned this Jan 16, 2025
@FrankYFTang
Copy link
Contributor Author

@richgillam @markusicu ping

markusicu
markusicu reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to rubber-stamp but curious about a couple of questions.

icu4c/source/i18n/gregoimp.cpp Outdated Show resolved Hide resolved
richgillam
richgillam previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay, but I feel like I lack the knowledge to say definitively that this issue good, or even to say with confidence I know what you're doing. But I'll trust you.

I do think Markus's question is a good one.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/gregoimp.cpp is different
  • icu4c/source/i18n/gregoimp.h is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
ICU-22991 Simplified Grego code
1c117de 
Use timeToFields instead of dayToFields

ICU-22991 Revert back gregoimp interface change
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

@markusicu PTAL

@FrankYFTang
Copy link
Contributor Author

@markusicu ping

@FrankYFTang FrankYFTang merged commit 4fc1b7e into unicode-org:main Jan 25, 2025
94 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22991-simp-C++ branch January 25, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@richgillam richgillam Awaiting requested review from richgillam

Assignees

@richgillam richgillam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @markusicu @richgillam