Skip to content

Commit

Permalink
Implement without_descendants and without_ancestors in datagen (#4846)
Browse files Browse the repository at this point in the history
Part of #4629

I rewrote `select_locales_for_key` and I think it is a lot cleaner and
comprehensible now.

---------

Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
  • Loading branch information
sffc and robertbastian authored Apr 30, 2024
1 parent daa13bb commit 006e2c2
Show file tree
Hide file tree
Showing 5 changed files with 453 additions and 184 deletions.
4 changes: 2 additions & 2 deletions provider/baked/collator/data/macros/collator_meta_v1.rs.data

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion provider/blob/src/export/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
//! DatagenDriver::new()
//! .with_keys([icu_provider::hello_world::HelloWorldV1Marker::KEY])
//! .with_all_locales()
//! .export(&DatagenProvider::new_latest_tested(), exporter)
//! .export(&icu_provider::hello_world::HelloWorldProvider, exporter)
//! .unwrap();
//!
//! // communicate the blob to the client application (network, disk, etc.)
Expand Down
2 changes: 1 addition & 1 deletion provider/blob/tests/test_versions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fn run_driver(exporter: BlobExporter) -> Result<(), DataError> {
DatagenDriver::new()
.with_keys([icu_provider::hello_world::HelloWorldV1Marker::KEY])
.with_locales_and_fallback([LocaleFamily::full()], Default::default())
.export(&DatagenProvider::new_custom(), exporter)
.export(&icu_provider::hello_world::HelloWorldProvider, exporter)
}

fn check_hello_world(blob_provider: impl DataProvider<HelloWorldV1Marker>) {
Expand Down
Loading

0 comments on commit 006e2c2

Please sign in to comment.