Correct H23 as the stored symbol for skeletons

unicode-org · Jul 2, 2021 · dc73213 · dc73213
1 parent 4c6f00c
commit dc73213
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/components/datetime/src/pattern/mod.rs b/components/datetime/src/pattern/mod.rs
@@ -288,7 +288,7 @@ impl Serialize for Pattern {
 }
 
 /// Used to represent either H11/H12, or H23/H24. Skeletons only store these
-/// hour cycles as H12 or H24.
+/// hour cycles as H12 or H23.
 #[derive(Debug, PartialEq, Clone, Copy)]
 #[cfg_attr(
     feature = "provider_serde",

diff --git a/components/datetime/src/pattern/transform_hour_cycle.rs b/components/datetime/src/pattern/transform_hour_cycle.rs
@@ -60,7 +60,7 @@ pub fn apply_coarse_hour_cycle(
                     // Mutate the pattern with the new symbol, so that it can be matched against.
                     *symbol = fields::FieldSymbol::Hour(match coarse_hour_cycle {
                         CoarseHourCycle::H11H12 => fields::Hour::H12,
-                        CoarseHourCycle::H23H24 => fields::Hour::H24,
+                        CoarseHourCycle::H23H24 => fields::Hour::H23,
                     });
                     break;
                 }

diff --git a/components/datetime/src/skeleton.rs b/components/datetime/src/skeleton.rs
@@ -236,13 +236,13 @@ impl From<&Pattern> for Skeleton {
                     //     FieldSymbol::DayPeriod(fields::DayPeriod::Flexible)
                     // }
 
-                    // Only the H12 and H24 symbols are used in skeletons, while the patterns may
+                    // Only the H12 and H23 symbols are used in skeletons, while the patterns may
                     // contain H11 or H23 depending on the localization.
                     FieldSymbol::Hour(fields::Hour::H11) | FieldSymbol::Hour(fields::Hour::H12) => {
                         FieldSymbol::Hour(fields::Hour::H12)
                     }
                     FieldSymbol::Hour(fields::Hour::H23) | FieldSymbol::Hour(fields::Hour::H24) => {
-                        FieldSymbol::Hour(fields::Hour::H24)
+                        FieldSymbol::Hour(fields::Hour::H23)
                     }
 
                     // Pass through all of the following preferences unchanged.